cmccabe commented on a change in pull request #9883:
URL: https://github.com/apache/kafka/pull/9883#discussion_r558590756
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1453,6 +1456,23 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:
Boolean, dynamicConfigO
val brokerIdGenerationEnable: Boolean =
getBoolean(KafkaConfig.BrokerIdGenerationEnableProp)
val maxReservedBrokerId: Int = getInt(KafkaConfig.MaxReservedBrokerIdProp)
var brokerId: Int = getInt(KafkaConfig.BrokerIdProp)
+ val processRoles = parseProcessRoles()
+
+ private def parseProcessRoles(): Set[ProcessRole] = {
+ val roles = getList(KafkaConfig.ProcessRolesProp).asScala.map {
+ case "broker" => BrokerRole
+ case "controller" => ControllerRole
+ case role => throw new ConfigException(s"Unknown process role $role")
Review comment:
can you list the valid roles in this exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
