hachikuji commented on a change in pull request #10005:
URL: https://github.com/apache/kafka/pull/10005#discussion_r569854419
##########
File path: core/src/main/scala/kafka/cluster/Partition.scala
##########
@@ -89,8 +88,7 @@ object Partition extends KafkaMetricsGroup {
val configProvider = new TopicConfigFetcher {
override def fetch(): Properties = {
- val adminZkClient = new AdminZkClient(replicaManager.zkClient)
- adminZkClient.fetchEntityConfig(ConfigType.Topic, topicPartition.topic)
+ replicaManager.configRepository.topicConfigs(topicPartition.topic())
Review comment:
We have access to the topic name in `Partition`, so my thought was to
replace the calls to `TopicConfigFetcher.fetch` with
`ConfigRepository.topicConfig(topic)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
