rondagostino commented on a change in pull request #10005:
URL: https://github.com/apache/kafka/pull/10005#discussion_r570326339
##########
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##########
@@ -348,15 +348,15 @@ class KafkaServer(
/* start processing requests */
dataPlaneRequestProcessor = new
KafkaApis(socketServer.dataPlaneRequestChannel, replicaManager, adminManager,
groupCoordinator, transactionCoordinator,
- kafkaController, forwardingManager, zkClient, config.brokerId,
config, metadataCache, metrics, authorizer, quotaManagers,
+ kafkaController, forwardingManager, zkClient, config.brokerId,
config, replicaManager.configRepository, metadataCache, metrics, authorizer,
quotaManagers,
Review comment:
@hachikuji After this change we have only 1 place left where we reach
into `ReplicaManager` to grab its `ConfigRepository` -- when we create a
`Partition` instance. Do you think we should change that so that we explicitly
provide the instance to the `Partition` constructor and the companion object's
`apply()` method? Aside form this last question I think we're all set here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
