hachikuji commented on a change in pull request #10005:
URL: https://github.com/apache/kafka/pull/10005#discussion_r570404954
##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -1881,7 +1884,11 @@ class ReplicaManager(val config: KafkaConfig,
logManager.handleLogDirFailure(dir)
if (sendZkNotification)
- zkClient.propagateLogDirEvent(localBrokerId)
+ if (zkClient == null) {
Review comment:
Can we make `zkClient` an `Option`? By the way, we are really close to
being able to remove `KafkaZkClient` as a dependency, but I guess we will first
need #9577.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
