ijuma commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r587471462
##########
File path: build.gradle
##########
@@ -1987,28 +2005,30 @@ project(':connect:json') {
archivesBaseName = "connect-json"
dependencies {
- compile project(':connect:api')
- compile libs.jacksonDatabind
- compile libs.jacksonJDK8Datatypes
- compile libs.slf4jApi
+ implementation project(':connect:api')
Review comment:
To clarify, `compile` is more like `api` than `implementation`. I
switched the dependency of `connect-api` for `connect-json` and
`connect-transform` to `api` for now. We can change this in a future API, if we
like, but it seems more consistent with the generally conservative approach
we're taking in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
