rhauch commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r586619026
##########
File path: build.gradle
##########
@@ -1987,28 +2005,30 @@ project(':connect:json') {
archivesBaseName = "connect-json"
dependencies {
- compile project(':connect:api')
- compile libs.jacksonDatabind
- compile libs.jacksonJDK8Datatypes
- compile libs.slf4jApi
+ implementation project(':connect:api')
Review comment:
I think this is the correct mapping.
By switching to `implementation`, any external project depending on the
`connect:json` module will have to include an explicit dependency on
`connect:api`. This appears to be have the same effect as what previous
branches do with `compile` on earlier branches, but using `implementation`
seems more correct since the [Gradle
docs](https://docs.gradle.org/current/userguide/java_library_plugin.html)
suggest that `compile` (or `compileOnly`) are more applicable for shading,
which is not our case here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
