chia7712 commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r586597356
##########
File path: build.gradle
##########
@@ -1833,27 +1848,30 @@ project(':jmh-benchmarks') {
apply plugin: 'com.github.johnrengelman.shadow'
shadowJar {
- baseName = 'kafka-jmh-benchmarks-all'
- classifier = null
Review comment:
Those changes rename the shadow jar from `kafka-jmh-benchmarks-all.jar`
to `kafka-jmh-benchmarks-all-3.0.0-SNAPSHOT-all.jar`. That breaks `jmh.sh` as
the script presumes the name of shadow jar is `kafka-jmh-benchmarks-all.jar`
(https://github.com/apache/kafka/blob/trunk/jmh-benchmarks/jmh.sh#L40)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
