ableegoldman commented on a change in pull request #10342:
URL: https://github.com/apache/kafka/pull/10342#discussion_r597281724
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##########
@@ -477,15 +441,7 @@ private void cleanRemovedTasksCalledByCleanerThread(final
long cleanupDelayMs) {
exception
);
} finally {
- try {
- unlock(id);
- } catch (final IOException exception) {
- log.warn(
- String.format("%s Swallowed the following
exception during unlocking after deletion of obsolete " +
- "state directory %s for task %s:",
logPrefix(), dirName, id),
- exception
- );
- }
+ unlock(id);
Review comment:
I think we need to keep that one because `Utils.delete` can throw
IOException too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
