ableegoldman commented on a change in pull request #10342:
URL: https://github.com/apache/kafka/pull/10342#discussion_r596443720
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##########
@@ -186,7 +186,7 @@ public ProcessorStateManager(final TaskId taskId,
this.changelogReader = changelogReader;
this.sourcePartitions = sourcePartitions;
- this.baseDir = stateDirectory.directoryForTask(taskId);
+ this.baseDir = stateDirectory.getOrCreateDirectoryForTask(taskId);
Review comment:
Note: the only logical changes are in `StateDirectory` and
`KafkaStreams`, the rest of the files were just touched by renaming this method
to include the `getOrCreate` prefix. Sorry for the expanded surface area, I
felt the renaming was merited since otherwise this critical functionality is
easy to miss.
There are also some non-renaming changes in StateManagerUtil and TaskManager
that just involve removing the try-catch logic for the no longer throwable
IOException. For tests, you should focus on `StateDirectoryTest` and
`StateManagerUtilTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
