ableegoldman commented on pull request #10342: URL: https://github.com/apache/kafka/pull/10342#issuecomment-802350667
@wcarlson5 that's a good question, and I totally agree we should be more careful about that. In theory we should always clean up all state including unlock task directories during a thread's shutdown, but it's possible something slips through and a task directory gets orphaned. I filed a ticket to address this a while back: see [KAFKA-10563](https://issues.apache.org/jira/browse/KAFKA-10563) That said, I think it's somewhat of an orthogonal concern and would prefer to do that in a separate PR to keep this one light. I don't think the changes here make that any better or worse -- if a dying thread orphaned some tasks, we weren't cleaning up the filesystem locks either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org