hachikuji commented on a change in pull request #10282:
URL: https://github.com/apache/kafka/pull/10282#discussion_r598141840
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1892,8 +1892,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:
Boolean, dynamicConfigO
}
}
+ // Topic IDs are used with all self-managed quorum clusters and ZK cluster
with IBP greater than or equal to 2.8
def usesTopicId: Boolean =
Review comment:
You are right that DeleteTopics must be handled by the active
controller. I think the point still stands with a slightly different scenario.
The controller might go from a new version with an updated IBP to an old
version during the roll. This could happen because of a session timeout. It is
an unlikely case to be sure, but still possible. I'd be inclined to remove the
check just to take it out of the picture. It doesn't seem to be buying us
anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
