[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

[GitBox]

cmccabe commented on a change in pull request #10705:
URL: https://github.com/apache/kafka/pull/10705#discussion_r633903456



##########
File path: raft/src/main/java/org/apache/kafka/raft/LeaderAndEpoch.java
##########
@@ -28,6 +28,10 @@ public LeaderAndEpoch(OptionalInt leaderId, int epoch) {
         this.epoch = epoch;
     }
 

Review comment:
       Hmm... 
   
   * What do you think of using `nodeId` rather than `leaderId`?
    
   * There should be an accessor function to get the `nodeId` out.
   
   * If we really need a shortcut method for comparing against specific node 
IDs like this, we could call it `LeaderAndEpoch#hasNodeId(int nodeId)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org