[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

[GitBox]

cmccabe commented on a change in pull request #10705:
URL: https://github.com/apache/kafka/pull/10705#discussion_r633906477



##########
File path: raft/src/main/java/org/apache/kafka/raft/LeaderAndEpoch.java
##########
@@ -28,6 +28,10 @@ public LeaderAndEpoch(OptionalInt leaderId, int epoch) {
         this.epoch = epoch;
     }
 

Review comment:
       Also, I just realized that all the data fields in here are public. Can 
we fix that? In Java we use public accessors, not public data fields, unless 
there's some really exceptional reason not to.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org