[GitHub] [kafka] cmccabe commented on a change in pull request #10705: KAFKA-12342: Reverse module dependency between Raft and Metadata

[GitBox]

cmccabe commented on a change in pull request #10705:
URL: https://github.com/apache/kafka/pull/10705#discussion_r633909171



##########
File path: 
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java
##########
@@ -209,136 +196,6 @@ public void testUnregisterBroker() throws Throwable {
         }
     }
 
-    static class MockSnapshotWriterBuilder implements Function<Long, 
SnapshotWriter> {

Review comment:
       I don't want to remove the snapshot handling code or tests that we have 
for the controller. We should find a way to keep this test working before we 
merge this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org