rondagostino commented on pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#issuecomment-843228313
@cmccabe I merged in trunk and pushed a separate commit to fix the failing
unit tests. The way we test to ensure an API is always forwarded for KRaft is
to send the request directly through into `KafkaApis` as though it wasn't
forwarded and assert that we get `UnsupportedVersionException`. You had
inadvertently short-circuited our ability to send the request through to
`KafkaApis` by invoking the new `AclApis` directly in the
`request.header.apiKey match {` block. I fixed the tests by re-adding the
standard `handle...()` methods and have them check the metadata support status
if necessary and then invoke `AclApis` -- that way we still have the check that
we are using ZooKeeper and not KRaft, and the tests can get the expected
exception and pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
