ableegoldman commented on a change in pull request #10740:
URL: https://github.com/apache/kafka/pull/10740#discussion_r637042507
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/SessionWindows.java
##########
@@ -84,17 +86,14 @@ private SessionWindows(final long gapMs, final long
graceMs) {
* Create a new window specification with the specified inactivity gap.
*
* @param inactivityGap the gap of inactivity between sessions
- * @return a new window specification with default maintain duration of 1
day
+ * @return a new window specification with default without any grace period
Review comment:
Sorry, it's kind of a subtle point -- we would like to essentially get
rid of the default, which means the grace period is always specified exactly by
the user. In the `withNoGracePeriod` APIs, the user has just specified the
grace period as 0 -- it's not a default 🙂
On top of that, we actually can't change the current behavior of the
existing APIs which we are deprecating here. That means those still need to set
the grace period as the old default of 24hr. Once the deprecation period has
passed, we can remove the DEFAULT_GRACE_PERIOD config when we remove the
deprecated APIs
Does that make sense? It might help to rename the DEFAULT_GRACE_PERIOD
config to make this more clear, eg to something like DEPRECATED_GRACE_PERIOD or
OLD_DEFAULT_GRACE_PERIOD -- WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
