izzyacademy commented on a change in pull request #10740:
URL: https://github.com/apache/kafka/pull/10740#discussion_r655661859



##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/Windows.java
##########
@@ -36,11 +36,11 @@
  * @see SessionWindows
  * @see TimestampExtractor
  */
+@SuppressWarnings("deprecation")
 public abstract class Windows<W extends Window> {
 
-    // By default grace period is 24 hours for all windows,
-    // in other words we allow out-of-order data for up to a day
-    protected static final long DEFAULT_GRACE_PERIOD_MS = 24 * 60 * 60 * 1000L;
+    // By default, there is no longer any grace period since Kafka 3.0
+    protected static final long DEFAULT_GRACE_PERIOD_MS = 0L;

Review comment:
       I am going to address that now, with the new code version




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to