[GitHub] [kafka] izzyacademy commented on a change in pull request #10740: Kafka 8613 kip 633 drop default grace period streams

[GitBox]

izzyacademy commented on a change in pull request #10740:
URL: https://github.com/apache/kafka/pull/10740#discussion_r655661049



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/kstream/SessionWindows.java
##########
@@ -84,17 +86,14 @@ private SessionWindows(final long gapMs, final long 
graceMs) {
      * Create a new window specification with the specified inactivity gap.
      *
      * @param inactivityGap the gap of inactivity between sessions
-     * @return a new window specification with default maintain duration of 1 
day
+     * @return a new window specification with default without any grace period

Review comment:
       @ableegoldman  I will change it now to DEPRECATED_OLD_24_HR_GRACE_PERIOD 
and for the zero grace period, I will use NO_GRACE_PERIOD as the constant




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org