cmccabe commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r658322252
########## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ########## @@ -74,6 +74,7 @@ object Defaults { val InitialBrokerRegistrationTimeoutMs = 60000 val BrokerHeartbeatIntervalMs = 2000 val BrokerSessionTimeoutMs = 9000 + val MetadataSnapshotMinNewRecordBytes = Int.MaxValue Review comment: Hmm... why not just set this to 100 MB for now (or whatever default we consider reasonable?) It won't harm anything to generate snapshots that the broker won't use, right? The controller itself can use them to start up more quickly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org