cmccabe commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658330688
##########
File path:
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java
##########
@@ -282,7 +285,71 @@ public void testSnapshotSaveAndLoad() throws Throwable {
logEnv.waitForSnapshot(snapshotLogOffset)
);
assertEquals(snapshotLogOffset,
snapshot.lastContainedLogOffset());
- checkSnapshotContents(fooId, brokerEpochs, snapshot);
+ checkSnapshotContent(
+ expectedSnapshotContent(fooId, brokerEpochs),
+ snapshot
+ );
+ }
+ }
+ }
+
+ @Test
+ public void testSnapshotConfiguration() throws Throwable {
+ final int numBrokers = 4;
+ final int minNewRecordBytes = 4;
+ Map<Integer, Long> brokerEpochs = new HashMap<>();
+ Uuid fooId;
+ try (LocalLogManagerTestEnv logEnv = new LocalLogManagerTestEnv(3,
Optional.empty())) {
+ try (QuorumControllerTestEnv controlEnv = new
QuorumControllerTestEnv(
+ logEnv,
Review comment:
logEnv doesn't need its own line, nor does builder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
