cmccabe commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658327187
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -374,6 +375,7 @@ object KafkaConfig {
val BrokerSessionTimeoutMsProp = "broker.session.timeout.ms"
val NodeIdProp = "node.id"
val MetadataLogDirProp = "metadata.log.dir"
+ val MetadataSnapshotMinNewRecordBytesProp =
"metadata.log.snapshot.min.new_record.bytes"
Review comment:
Hmm, I think we should avoid underscores in configuration key names.
Also, min.new_record.bytes is a bit unclear (to me at least).
How about `metadata.log.max.record.bytes.between.snapshots` ?
It is really a "max" rather than "min" because the idea is we'll take the
snapshot once the max is hit. So combining with other conditions (time, etc.)
this puts a (rough) ceiling on the number of record bytes between each snapshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
