rajinisivaram commented on a change in pull request #10962: URL: https://github.com/apache/kafka/pull/10962#discussion_r664798710
########## File path: clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java ########## @@ -174,6 +315,28 @@ public boolean isAllPartitions() { return data.topics() == ALL_TOPIC_PARTITIONS; } + public boolean isAllPartitionsForGroup(String groupId) { + OffsetFetchRequestGroup group = data + .groupIds() + .stream() + .filter(g -> g.groupId().equals(groupId)) + .collect(toSingleton()); + return group.topics() == ALL_TOPIC_PARTITIONS_BATCH; + } + + // Custom collector to filter a single element + private <T> Collector<T, ?, T> toSingleton() { Review comment: Can we a add a test in the new `kafka.server.OffsetFetchRequestTest`? Can do that in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org