rajinisivaram commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r664806203
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java
##########
@@ -174,6 +315,28 @@ public boolean isAllPartitions() {
return data.topics() == ALL_TOPIC_PARTITIONS;
}
+ public boolean isAllPartitionsForGroup(String groupId) {
+ OffsetFetchRequestGroup group = data
+ .groupIds()
+ .stream()
+ .filter(g -> g.groupId().equals(groupId))
+ .collect(toSingleton());
+ return group.topics() == ALL_TOPIC_PARTITIONS_BATCH;
+ }
+
+ // Custom collector to filter a single element
+ private <T> Collector<T, ?, T> toSingleton() {
Review comment:
Same test class `OffsetFetchRequestTest.scala`, a test with v8 with a
batched request where the same group appears twice, perhaps with different
topics. The response should be either InvalidRequestException because we want
to treat it as an error OR actual offsets because we handle the request
correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
