skaundinya15 commented on a change in pull request #10962: URL: https://github.com/apache/kafka/pull/10962#discussion_r664803616
########## File path: core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala ########## @@ -0,0 +1,227 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package kafka.server + +import kafka.utils.TestUtils +import org.apache.kafka.clients.consumer.{ConsumerConfig, OffsetAndMetadata} +import org.apache.kafka.common.TopicPartition +import org.apache.kafka.common.protocol.{ApiKeys, Errors} +import org.apache.kafka.common.requests.{AbstractResponse, OffsetFetchRequest, OffsetFetchResponse} +import org.junit.jupiter.api.Assertions.{assertEquals, assertTrue} +import org.junit.jupiter.api.{BeforeEach, Test} + +import java.util +import java.util.Collections.singletonList +import scala.jdk.CollectionConverters._ +import java.util.{Optional, Properties} + +class OffsetFetchRequestTest extends BaseRequestTest{ + + override def brokerCount: Int = 1 + + val brokerId: Integer = 0 + val offset = 15L + val leaderEpoch: Optional[Integer] = Optional.of(3) + val metadata = "metadata" + + override def brokerPropertyOverrides(properties: Properties): Unit = { + properties.put(KafkaConfig.BrokerIdProp, brokerId.toString) + properties.put(KafkaConfig.OffsetsTopicPartitionsProp, "1") + properties.put(KafkaConfig.OffsetsTopicReplicationFactorProp, "1") + properties.put(KafkaConfig.TransactionsTopicPartitionsProp, "1") + properties.put(KafkaConfig.TransactionsTopicReplicationFactorProp, "1") + properties.put(KafkaConfig.TransactionsTopicMinISRProp, "1") + } + + @BeforeEach + override def setUp(): Unit = { + doSetup(createOffsetsTopic = false) + + TestUtils.createOffsetsTopic(zkClient, servers) + } + + @Test + def testOffsetFetchRequestLessThanV8(): Unit = { + val topic = "topic" + createTopic(topic) + + val groupId = "groupId" + val tpList = singletonList(new TopicPartition(topic, 0)) + val topicOffsets = tpList.asScala.map{ + tp => (tp, new OffsetAndMetadata(offset, leaderEpoch, metadata)) + }.toMap.asJava + + consumerConfig.setProperty(ConsumerConfig.GROUP_ID_CONFIG, groupId) + val consumer = createConsumer() + consumer.assign(tpList) + consumer.commitSync(topicOffsets) + consumer.close() + // testing from version 1 onward since version 0 read offsets from ZK + for (version <- 1 to ApiKeys.OFFSET_FETCH.latestVersion()) { + if (version < 8) { + val request = + if (version < 7) { + new OffsetFetchRequest.Builder( + groupId, false, tpList, false) + .build(version.asInstanceOf[Short]) + } else { + new OffsetFetchRequest.Builder( + groupId, false, tpList, true) + .build(version.asInstanceOf[Short]) + } + val response = connectAndReceive[OffsetFetchResponse](request) + val topicData = response.data().topics().get(0) + val partitionData = topicData.partitions().get(0) + if (version < 3) { + assertEquals(AbstractResponse.DEFAULT_THROTTLE_TIME, response.throttleTimeMs()) + } + assertEquals(Errors.NONE, response.error()) + assertEquals(topic, topicData.name()) + assertEquals(0, partitionData.partitionIndex()) + assertEquals(offset, partitionData.committedOffset()) + if (version >= 5) { + // committed leader epoch introduced with V5 + assertEquals(leaderEpoch.get(), partitionData.committedLeaderEpoch()) + } + assertEquals(metadata, partitionData.metadata()) + assertEquals(Errors.NONE.code(), partitionData.errorCode()) + } + } + } + + @Test + def testOffsetFetchRequestV8AndAbove(): Unit = { + val groupOne = "group1" + val groupTwo = "group2" + val groupThree = "group3" + val groupFour = "group4" + val groupFive = "group5" Review comment: I refactored this test class a bit to make use of more helper methods - is there something additional we can do here to make it work on a collection of groups? Are you suggesting adding an additional method that can create some number of groups that we can use the test with? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
