jolshan commented on a change in pull request #10952:
URL: https://github.com/apache/kafka/pull/10952#discussion_r670553369
##########
File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java
##########
@@ -377,6 +397,12 @@ else if (metadata.error() ==
Errors.TOPIC_AUTHORIZATION_FAILED)
log.debug("Updating last seen epoch for partition {} from {}
to epoch {} from new metadata", tp, currentEpoch, newEpoch);
lastSeenLeaderEpochs.put(tp, newEpoch);
return Optional.of(partitionMetadata);
+ // If both topic IDs were valid and the topic ID changed, update
the metadata
+ } else if (!topicId.equals(Uuid.ZERO_UUID) && oldTopicId != null
&& !topicId.equals(oldTopicId)) {
Review comment:
This bugged me a bit too. The issue is that the request itself uses
Uuid.ZERO_UUID, so we'd just have to convert that to null. We can do that if it
is clearer to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
