jolshan commented on a change in pull request #10952:
URL: https://github.com/apache/kafka/pull/10952#discussion_r670557519
##########
File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java
##########
@@ -377,6 +397,12 @@ else if (metadata.error() ==
Errors.TOPIC_AUTHORIZATION_FAILED)
log.debug("Updating last seen epoch for partition {} from {}
to epoch {} from new metadata", tp, currentEpoch, newEpoch);
lastSeenLeaderEpochs.put(tp, newEpoch);
return Optional.of(partitionMetadata);
+ // If both topic IDs were valid and the topic ID changed, update
the metadata
+ } else if (!topicId.equals(Uuid.ZERO_UUID) && oldTopicId != null
&& !topicId.equals(oldTopicId)) {
+ log.debug("Topic ID for partition {} changed from {} to {}, so
this topic must have been recreated. " +
+ "Using the newly updated metadata.", tp,
oldTopicId, topicId);
Review comment:
So part of the reason why I say this is that this method decides whether
we use or ignore the new metadata to update the cache in general. But I can
change to the epoch message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
