jolshan commented on a change in pull request #10952:
URL: https://github.com/apache/kafka/pull/10952#discussion_r670658031



##########
File path: clients/src/test/java/org/apache/kafka/clients/MetadataTest.java
##########
@@ -845,6 +887,7 @@ protected boolean retainTopic(String topic, boolean 
isInternal, long nowMs) {
         assertEquals(cluster.topics(), new 
HashSet<>(Arrays.asList("oldValidTopic", "keepValidTopic")));
         assertEquals(cluster.partitionsForTopic("oldValidTopic").size(), 2);
         assertEquals(cluster.partitionsForTopic("keepValidTopic").size(), 3);
+        assertTrue(cluster.topicIds().containsAll(topicIds.values()));

Review comment:
       The collection types are different so I made a helper method to test 
both containAll. There may have been a helper somewhere else in the code but I 
couldn't find it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to