hachikuji commented on a change in pull request #11231:
URL: https://github.com/apache/kafka/pull/11231#discussion_r694230654
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -476,7 +476,6 @@ boolean joinGroupIfNeeded(final Timer timer) {
else if (!future.isRetriable())
throw exception;
- resetStateAndRejoin(String.format("rebalance failed with
retriable error %s", exception));
Review comment:
@guozhangwang Thanks. Could you mention a case of a retriable exception
where we would need to call `onJoinPrepare`? At a high level, I think we
should only need `onJoinPrepare` if there has been some change to the
membership. If we fall out of the group after an `UNKNOWN_MEMBER_ID` error,
then we need `onJoinPrepare`, but if we're retrying after a disconnect, I can't
think why we need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
