dajac commented on a change in pull request #11231:
URL: https://github.com/apache/kafka/pull/11231#discussion_r694568169
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -476,7 +476,6 @@ boolean joinGroupIfNeeded(final Timer timer) {
else if (!future.isRetriable())
throw exception;
- resetStateAndRejoin(String.format("rebalance failed with
retriable error %s", exception));
Review comment:
I have double checked the error handling as well and I do agree with the
change as all the errors, which requires to rejoin, are explicitly handled in
the `JoinResponseHandler` and the `SyncGroupResponseHandler`. The change looks
good to me.
I do agree with @guozhangwang that reseting `rejoinNeeded` would make the
whole logic a bit cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
