vincent81jiang commented on a change in pull request #11327:
URL: https://github.com/apache/kafka/pull/11327#discussion_r710426469
##########
File path: core/src/main/scala/kafka/log/LogCleaner.scala
##########
@@ -87,17 +87,23 @@ import scala.util.control.ControlThrowable
* @param logDirs The directories where offset checkpoints reside
* @param logs The pool of logs
* @param time A way to control the passage of time
+ * @param scheduler The thread pool scheduler used for background actions
*/
class LogCleaner(initialConfig: CleanerConfig,
val logDirs: Seq[File],
val logs: Pool[TopicPartition, UnifiedLog],
val logDirFailureChannel: LogDirFailureChannel,
- time: Time = Time.SYSTEM) extends Logging with
KafkaMetricsGroup with BrokerReconfigurable
+ time: Time = Time.SYSTEM,
+ private[log] val scheduler: Scheduler) extends Logging with
KafkaMetricsGroup with BrokerReconfigurable
{
/* Log cleaner configuration which may be dynamically updated */
@volatile private var config = initialConfig
+ // Visible for testing
+ val housekeepingDelayMs = 30000
+ val housekeepingIntervalMs = 30000
Review comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
