vincent81jiang commented on a change in pull request #11327: URL: https://github.com/apache/kafka/pull/11327#discussion_r713458476
########## File path: core/src/main/scala/kafka/log/LogCleanerManager.scala ########## @@ -511,6 +513,27 @@ private[log] class LogCleanerManager(val logDirs: Seq[File], uncleanablePartitions.get(log.parentDir).exists(partitions => partitions.contains(topicPartition)) } } + + def maintainUncleanablePartitions(): Unit = { Review comment: Pushed a new iteration. Would like to hear your opinion on which way is better. (Didn't put it in LogCleanerManager.grabFilthiestCompactedLog because grabFilthiestCompactedLog checks current logs, maintenance task checks uncleanablePartitions, they're not closely related.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org