vincent81jiang commented on a change in pull request #11327:
URL: https://github.com/apache/kafka/pull/11327#discussion_r713451787
##########
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##########
@@ -511,6 +513,27 @@ private[log] class LogCleanerManager(val logDirs:
Seq[File],
uncleanablePartitions.get(log.parentDir).exists(partitions =>
partitions.contains(topicPartition))
}
}
+
+ def maintainUncleanablePartitions(): Unit = {
Review comment:
@junrao, I tried to put the logic in LogCleaner.doWork at the beginning
(which I feel is similar to LogCleanerManager.grabFilthiestCompactedLog) but
then reverted the change simply because maintenance work performed more
frequently. If the overhead of frequent maintenance is not a concern (I assume
the maintenance task is cheap), we can definitely do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
