jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r710561967
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java
##########
@@ -328,22 +329,18 @@ public int maxBytes() {
} else {
name = topicNames.get(fetchTopic.topicId());
}
- if (name != null) {
- // If topic name is resolved, simply add to
fetchData map
- fetchTopic.partitions().forEach(fetchPartition ->
- fetchData.put(new TopicPartition(name,
fetchPartition.partition()),
- new PartitionData(
-
fetchPartition.fetchOffset(),
-
fetchPartition.logStartOffset(),
-
fetchPartition.partitionMaxBytes(),
-
optionalEpoch(fetchPartition.currentLeaderEpoch()),
-
optionalEpoch(fetchPartition.lastFetchedEpoch())
- )
- )
- );
- } else {
- throw new
UnknownTopicIdException(String.format("Topic Id %s in FetchRequest was unknown
to the server", fetchTopic.topicId()));
- }
+ // If topic name is resolved, simply add to fetchData
map
Review comment:
nit: remove comment -- we add unresolved names now too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
