jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r710592488
##########
File path: core/src/main/scala/kafka/server/FetchSession.scala
##########
@@ -526,11 +532,11 @@ class IncrementalFetchContext(private val time: Time,
}
}
if (hasInconsistentTopicIds) {
- FetchResponse.of(Errors.INCONSISTENT_TOPIC_ID, 0, session.id, new
FetchSession.RESP_MAP, Collections.emptyMap())
+ FetchResponse.of(Errors.INCONSISTENT_TOPIC_ID, 0, session.id, new
FetchSession.RESP_MAP)
Review comment:
Since we moved an inconsistent topic ID check to the FetchResponse.of
method we may want to remove this and similar checks in other contexts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
