jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r712495759
##########
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##########
@@ -761,16 +836,16 @@ class FetchSessionTest {
request2.isFromFollower,
request2.fetchData(topicNames),
request2.forgottenTopics(topicNames),
- topicIds
+ topicNames
)
assertEquals(classOf[SessionErrorContext], context2.getClass)
- val respData2 = new util.LinkedHashMap[TopicPartition,
FetchResponseData.PartitionData]
+ val respData2 = new util.LinkedHashMap[TopicIdPartition,
FetchResponseData.PartitionData]
assertEquals(Errors.FETCH_SESSION_TOPIC_ID_ERROR,
context2.updateAndGenerateResponseData(respData2).error())
}
- @Test
+ /*@Test
Review comment:
I commented out this test, since I removed the behavior to catch
inconsistent IDs at this stage. I can try to simulate catching the inconsistent
ID later, but not sure if that is helpful to show in a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
