vincent81jiang commented on a change in pull request #11327:
URL: https://github.com/apache/kafka/pull/11327#discussion_r715169127
##########
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##########
@@ -512,6 +514,27 @@ private[log] class LogCleanerManager(val logDirs:
Seq[File],
uncleanablePartitions.get(log.parentDir).exists(partitions =>
partitions.contains(topicPartition))
}
}
+
+ def maintainUncleanablePartitions(): Unit = {
+ // Remove deleted partitions from uncleanablePartitions
+ inLock(lock) {
+ // Remove non-existing logDir
+ // Note: we don't use retain or filterInPlace method in this function
because retain is deprecated in
+ // scala 2.13 while filterInPlace is not available in scala 2.12.
+ val logDirsToRemove = uncleanablePartitions.filterNot {
+ case (logDir, _) => logDirs.map(_.getAbsolutePath).contains(logDir)
+ }.keys.toList
+ logDirsToRemove.foreach { uncleanablePartitions.remove(_) }
+
+ uncleanablePartitions.values.foreach {
+ partitions =>
+ // Remove deleted partitions
+ val partitionsToRemove =
partitions.filterNot(logs.contains(_)).toList
+ partitionsToRemove.foreach { partitions.remove(_) }
Review comment:
Yes, agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
