dajac commented on a change in pull request #11504:
URL: https://github.com/apache/kafka/pull/11504#discussion_r754898485
##########
File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala
##########
@@ -867,6 +868,39 @@ class SocketServerTest {
}
}
+ @Test
+ def testExceptionInAcceptor(): Unit = {
+ val overrideNum = server.config.maxConnectionsPerIp + 1
+ val overrideProps = TestUtils.createBrokerConfig(0,
TestUtils.MockZkConnect, port = 0)
+ overrideProps.put(KafkaConfig.MaxConnectionsPerIpOverridesProp,
s"localhost:$overrideNum")
Review comment:
Sorry, I was not clear here. Yes, we do need `overrideProps`. However, I
think that we don't need to set `MaxConnectionsPerIpOverridesProp`, do we? If
not, we could remove it and also remove `overrideNum`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
