vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r755099262



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingKeyValueStore.java
##########
@@ -155,6 +169,11 @@ private void putInternal(final Bytes key,
                 context.timestamp(),
                 context.partition(),
                 context.topic()));
+        if (context.recordMetadata().isPresent() && consistencyEnabled) {

Review comment:
       We need to record the position here as well as reads might be served 
directly from the cache




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to