vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r755096395
########## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogRecordDeserializationHelper.java ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.processor.internals; + +import org.apache.kafka.common.header.internals.RecordHeader; + +/** + * Changelog records without any headers are considered old format. + * New format changelog records will have a version in their headers. + * Version 0: This indicates that the changelog records are under version control. + * Version 1: This indicates that the changelog records have consistency information. + */ +public class ChangelogRecordDeserializationHelper { + private static final byte[] V_0_CHANGELOG_VERSION_HEADER_VALUE = {(byte) 0}; Review comment: We want to have version control for changelog records. `V0` means that the changelog records will have headers from now but these headers are empty and not used. `V_1` means that the headers contain consistency information. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
