[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

[GitBox]

vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r760111821



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStore.java
##########
@@ -79,15 +94,21 @@ public void init(final StateStoreContext context, final 
StateStore root) {
     }
 
     @Override
+    @SuppressWarnings("unchecked")
     public void remove(final Windowed<Bytes> sessionKey) {
         wrapped().remove(sessionKey);
-        context.logChange(name(), SessionKeySchema.toBinary(sessionKey), null, 
context.timestamp());
+        context.logChange(name(), SessionKeySchema.toBinary(sessionKey), null, 
context.timestamp(), position);

Review comment:
       We need to log a position here since we don't want mixed records (some 
that have and some that don't have headers with consistency info) in the 
changelog. In any case, the position is ignored during restoration for 
tombstones




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org