vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r761138847
########## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueBytesStore.java ########## @@ -76,6 +87,10 @@ public long approximateNumEntries() { public void put(final Bytes key, final byte[] value) { wrapped().put(key, value); + if (context != null && context.recordMetadata().isPresent()) { Review comment: @vvcephei when can the context be null? I copied this check from your POC but it wasn't everywhere so I am not sure where we need it. I guess the safest is to add it everywhere -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org