vvcephei commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r765060632
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStore.java
##########
@@ -79,15 +94,21 @@ public void init(final StateStoreContext context, final
StateStore root) {
}
@Override
+ @SuppressWarnings("unchecked")
public void remove(final Windowed<Bytes> sessionKey) {
wrapped().remove(sessionKey);
- context.logChange(name(), SessionKeySchema.toBinary(sessionKey), null,
context.timestamp());
+ context.logChange(name(), SessionKeySchema.toBinary(sessionKey), null,
context.timestamp(), position);
Review comment:
Yep, I think that's correct anyhow, since deleting a record from a store
is also an update to its state, and the position should uniquely correspond to
whether you see the delete or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
