vvcephei commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r765062259
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##########
@@ -106,10 +111,13 @@
private final RocksDBMetricsRecorder metricsRecorder;
protected volatile boolean open = false;
+ // VisibleForTesting
+ protected Position position;
+
private StateStoreContext context;
- private Position position;
- RocksDBStore(final String name,
+ // VisibleForTesting
+ public RocksDBStore(final String name,
Review comment:
Update: I didn't wind up returning the position information in the
framework PR, so the comment still applies. I think we'll revise this once
we're able to get the position from the public API, but for now this is just
fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
