[GitHub] [kafka] vvcephei commented on a change in pull request #11513: KAFKA-13506: Write and restore position to/from changelog

[GitBox]

vvcephei commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r765074461



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStoreTest.java
##########
@@ -103,18 +142,22 @@ public void shouldLogPuts() {
 
     @Test
     public void shouldLogRemoves() {
+        System.out.println("First call");
         inner.remove(key1);
         EasyMock.expectLastCall();
 
         init();
+        System.out.println("Second call");

Review comment:
       ```suggestion
   ```

##########
File path: 
streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStoreTest.java
##########
@@ -103,18 +142,22 @@ public void shouldLogPuts() {
 
     @Test
     public void shouldLogRemoves() {
+        System.out.println("First call");
         inner.remove(key1);
         EasyMock.expectLastCall();
 
         init();
+        System.out.println("Second call");
         store.remove(key1);
 
         final Bytes binaryKey = SessionKeySchema.toBinary(key1);
 
         EasyMock.reset(context);
-        context.logChange(store.name(), binaryKey, null, 0L);
+        
EasyMock.expect(context.recordMetadata()).andStubReturn(Optional.empty());
+        context.logChange(store.name(), binaryKey, null, 0L, 
Position.emptyPosition());
 
         EasyMock.replay(context);
+        System.out.println("Third call");

Review comment:
       ```suggestion
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org