showuon commented on pull request #11800:
URL: https://github.com/apache/kafka/pull/11800#issuecomment-1051784959
> unknownKeys contains neither usedKeys nor unusedKeys.
> Only configKeys that are not officially recognized by kafka will be put
into unknownKeys.
Yes, this is what I expected. Thanks.
But that also confuses me: if `unknown` keys doesn't contain `used` and
`unused`, why this test will fail after we assert `unknown`?
> However, after valuesWithPrefixOverride.get("sasl.mechanism") add
assertFalse(config.unknown().contains("prefix.sasl.mechanism"));,
testCase will fail to verify; because unknownKeys is only affected by
originals and values, the value is originalKeys.removeAll(valueKeys).
In the above test case, we originally expect that `prefix.sasl.mechanism` is
`used` and is not in `unused` keys. After this PR, we should expected that
`prefix.sasl.mechanism` is `used`, and not in `unused` and **NOT** in
`unknown` keys, right? Did I miss anything here?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
