showuon commented on pull request #11800: URL: https://github.com/apache/kafka/pull/11800#issuecomment-1051843328
> unknownKeys = originals.keySet().removeAll(values.keySet()) unknownKeys should not be changed after AbstractConfig is initialized. That looks good, but I think that doesn't work in some cases, like the `prefix` case. I'm not very familiar with the prefix logic, but I think the prefix is dynamic added to the `config key`. So that would make your assumption (unknownKeys should not be changed after AbstractConfig is initialized) failed. Could you make sure if your logic works in dynamic `prefix` case? (i.e. the `testValuesWithPrefixOverride` test case or other similar one) Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
