RivenSun2 commented on pull request #11800: URL: https://github.com/apache/kafka/pull/11800#issuecomment-1051834698
Or we add an instance variable `AbstractConfig.unknownKeys`, we can complete the assignment to the variable `unknownKeys` when `AbstractConfig` is initialized. `unknownKeys = originals.keySet().removeAll(values.keySet())` `unknownKeys` should not be changed after `AbstractConfig` is initialized. In this way, in the `unknown()` method, we directly return `unknownKeys` to avoid recalculating unknownKeys each time. What do you think? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
