[GitHub] [kafka] vamossagar12 commented on a change in pull request #11959: MINOR: log warning when topology override for cache size is non-zero

[GitBox]

vamossagar12 commented on a change in pull request #11959:
URL: https://github.com/apache/kafka/pull/11959#discussion_r837360780



##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -1047,9 +1048,9 @@ private static Metrics getMetrics(final StreamsConfig 
config, final Time time, f
                 // and then resize them later
                 streamThread = createAndAddStreamThread(0L, 0L, threadIdx);
                 final int numLiveThreads = getNumLiveStreamThreads();
-                resizeThreadCacheAndBufferMemory(numLiveThreads + 1);
+                resizeThreadCacheAndBufferMemory(numLiveThreads);
                 log.info("Adding StreamThread-{}, there are now {} threads 
with cache size/max buffer size values as {} per thread.",
-                        threadIdx, numLiveThreads + 1, 
getThreadCacheAndBufferMemoryString());
+                        threadIdx, numLiveThreads, 
getThreadCacheAndBufferMemoryString());

Review comment:
       ok.. yeah there are 2 more tests for threadReplacement which seem to be 
printing out an extra thread count. But I agree, a test for thread addition 
would be good..
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org