ableegoldman commented on a change in pull request #11959:
URL: https://github.com/apache/kafka/pull/11959#discussion_r838111680
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##########
@@ -466,64 +468,9 @@ public void close() {
waitForTransitionFromRebalancingToRunning();
for (final String log : appender.getMessages()) {
- // after we replace the thread there should be two
remaining threads with 5 bytes each
- if (log.endsWith("Adding StreamThread-3, there are now 3
threads with cache size/max buffer size values as 3/178956970 per thread.")) {
Review comment:
Apparently there was already a test for the cache being sized correctly
after a thread replacement/addition, I'm guessing this was updated with the
incorrect values in the PR that introduced the off by one bug -- probably
should have been a red flag if the value of the cache size changed here, not to
mention the comment above which explicitly mentions it should be 5 bytes per
thread 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
