In principle, I agree with everything Sebastian said...at least for the src versions. (I still have to think about his comments on the binary versions.) Mike is correct about JMeter having a different target audience than most Jakarta projects. However, I think that the assumptions change a bit for source distributions -- if you download the source distribution you fall into the "developer" category rather than just a "user". Of course, if we split the binary distribution as Sebastian suggested, the "external jars" part could be used with the source distribution too, which might simplify things a bit.
In spite of this, I'll still give my thumbs up to Mike for including the external jars in the source distribution for this release. This matches (I think) how it's been done in past JMeter releases, and it is also the simplest option. Since we're already a few days behind the binary 1.9 release, simple is good. Let's wait for the next release before we make big changes to how we distribute everything.
Jeremy
Sebastian Bazley wrote:
I agree that src_dist should just include the source files, and not any external jars, and should ideally only include the xml docs, not the generated html ones.
Building JMeter would obviously require the run-time jars, but these would be needed for the binary distribution as well - I don't see any point in including them in both source and binary distributions.
It may be worth splitting the binary distribution into two: - the external jars - the rest of the existing binary distribution. [Perhaps remove the HTML files from docs, and keep just the printable_docs versions?]
As to including Ant in the distribution, I agree with Jeremy that it should not be included. It seems to me that developers are likely to have this installed anyway, and Ant is surely now stable enough that any recent version will build JMeter.
As far as I can tell, the only other external dependency is Anakia (Velocity), which is needed to create the documentation. This could perhaps be included in the source distribution, but I think it would be better just to leave up to developers to download it separately. As with Ant, they might already have it. The build.xml file can be updated to allow anakia to be picked up from lib/ and/or ../jakarta-site2/.
Which reminds me: I would like to propose some enhancements to build.xml:
- allow the source/binary distributions to be created without rebuilding everything. This can be done by introducing two new targets which just do the tar/[g]zip etc. These targets could be marked "internal", i.e. no description. E.g. Make "dist" depend on "dist_tar", and move the tar/gzip/zip to dist_tar. Similarly for src_dist. [The original dist and src_dist targets would still do the same work, but refactored.]
- similarly, add a target (test_only ?) that can be used to test JMeter without needing to do a full build. At present, this means one cannot test a binary JMeter distribution. [One would need to include build.xml and bin/testfiles in binary distributions.]
- be able to use build.xml without needing build.sh or build.bat (e.g. use "ant [target]" or Eclipse) As it stands, build.bat does not agree with build.sh on where to look for libraries. Also, some of the classpath information is in build.xml and some is in build.xxx, which is not ideal.
This means updating some classpath definitions, and adding a classpath for Anakia. I've got this working on Windows XP.
I've not yet had a chance to try this on Unix, but when I do, I can post a patch to Buzilla - unless there are any
objections/further suggestions?
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
